M13: EXLA gradient conformance - #23
Merged
Merged
Conversation
Add a third gradient oracle — EXLA (XLA CPU backend) — to catch bugs where Emily and BinaryBackend agree on the wrong gradient (they share the same Nx.Defn.grad lowering). Eight zoo functions plus a full transformer-block training step are tested against checked-in EXLA golden values with per-function tolerance tables. - Extract shared defn functions into Emily.GradZoo - Generate golden values via bench/exla_golden_gen.exs (EXLA 0.11.0 CPU) - Test harness at test/emily/grad/exla_oracle_test.exs - CUDA conformance deferred to post-1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nx.BinaryBackendand MLXdefngrad functions intoEmily.GradZoo(eliminates duplication across test files)Mix.installscript:elixir bench/exla_golden_gen.exsTest plan
mix test test/emily/grad/— all 22 tests pass (equivalence, finite-diff, EXLA oracle)mix test --only grad_conformance— 9 EXLA oracle tests pass in isolationmix precommit— full suite greenNote: pre-existing flaky test in
transform_test.exs:105(seed-dependent, 15% tolerance boundary) — documented in PLAN.md, not introduced by this PR.