Fix flaky quantization round-trip test - #24
Merged
Conversation
Pin Axon init to a fixed seed so glorot_uniform produces deterministic weights. The 15 % relative-error threshold sat right at the boundary for some random initialisations. Split Axon.build into separate init (Evaluator + seed) and predict (target compiler) calls so the :seed option doesn't bleed through to Emily.Compiler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
42) soglorot_uniformproduces deterministic weights — the 15% relative-error threshold was borderline for some random initialisationsAxon.buildinto separate init (Evaluator + seed) and predict (target compiler) calls to avoid:seedbleeding through toEmily.CompilerTest plan
mix precommitpasses (all 361 tests, credo, format, compile)