fix: tighten operator-facing diagnostics - #22
Conversation
Correct the RELEASES help and simplify relup and startup messages. Keep versions, paths, commands, and recovery steps while removing OTP protocol detail. Closes #20 Co-Authored-By: Codex GPT-5 <noreply@openai.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7a37d3020
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Both display guards matched `[[:space:]]` beside `[[:cntrl:]]`, so a version carrying the space the parser deliberately preserves - OTP builds its marker as `EVsn ++ " " ++ Vsn`, and the split keeps the remainder exactly, because Mix permits spaces in versions - was reported as `<non-empty line containing whitespace or control bytes>`. That is the case where naming the release matters most. The pair can fail to settle for a reason with nothing to do with the version at all (mismatched markers, a version directory with no `env.sh`), and the label was then the only thing telling the operator which releases to go and inspect. It withheld exactly that. Match `[[:cntrl:]]` alone. Every whitespace byte that is genuinely unsafe to print - tab, newline, carriage return, vertical tab, form feed - is also a control byte, so nothing that had to be withheld stops being withheld. The new test covers both display branches, since both carried the same guard, and asserts the versions appear verbatim rather than that some label is absent. Claude-Session: https://claude.ai/code/session_01RotroiBdbidiCRX3KqE3Dy Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Validation
mix precommitReview
Claude Code adversarial review ran for the configured five-round maximum. All findings were addressed. The final round found four additional issues; those fixes landed after the review cap, so no sixth review was run. The exact squashed history passed
mix precommitafterward.Closes #20