Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the cursor issue if vscodevim.vim is installed #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AbhinavNmdo
Copy link
Contributor

No description provided.

@austenc
Copy link
Owner

austenc commented Aug 25, 2024

Hi @AbhinavNmdo and thank you for contributing! Do you mind explaining what the issue is? I’m not exactly sure what this PR is trying to fix yet. Thank you!

@AbhinavNmdo
Copy link
Contributor Author

This PR is to fix the cursor position if you are using VIM extension.

Before this PR:
{{| }}

After this PR:
{{ | }}

@AbhinavNmdo
Copy link
Contributor Author

Hi, @austenc have you reviewed my changes?

@austenc
Copy link
Owner

austenc commented Sep 6, 2024

@AbhinavNmdo I haven't gotten a chance to test them yet. I was at Laracon last week in Dallas, then flew to Kentucky and just got home yesterday.

However, I'm not seeing the same behavior you're mentioning. Are you sure it's not another extension that's causing that behavior? I have VSCodeVim enabled in my setup and it already works correctly (without this PR).

Can you try disabling all your extensions and then enabling only vim extension and this one to see if the broken behavior still happens for you?

@austenc
Copy link
Owner

austenc commented Sep 30, 2024

@AbhinavNmdo any updates on this? I'd love to fix the bug but need to know how to replicate it first. The issue with cursor position isn't happening for me with the existing version. Let me know, thank you!

@austenc
Copy link
Owner

austenc commented Oct 29, 2024

@AbhinavNmdo are you using cursor editor instead of normal VS Code perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants