Add logging of User-Agents#52
Draft
HeadedBranch wants to merge 6 commits intoaustin-weeks:mainfrom
Draft
Conversation
Contributor
Author
|
oh yeah forgot I need to fix the tests too |
Contributor
Author
|
The files are just being a bit of a pain tbh, it might just be easiest to go straight to a database as the datatypes are easier to work with, what database and crate should be used? |
Owner
|
I don't have a ton of experience working with databases in rust, so not sure what the best crate for that is. I think SQLite is the way to go though since we're basically just storing a single table of key-value pairs and we can just store it in a single file. |
Contributor
Author
|
I am currently working on making it work with a database and am having an annoying issue where it won't allow me to use my custom type for logging due to trait issues, the code should work if the traits issue gets sorted but I am very confused by it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds logging of the useragents that request the page