Avoid forcing installation of both httpx and requests
#26
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and requests - Move httpx and requests from core dependencies to optional extras - Add 'all' extra for users who want both libraries - Update README to reflect new installation instructions - Update noxfile to install both extras for testing Previously, both httpx and requests were always installed even when users only wanted one library. Now users can install only what they need: - retryhttp[all] for both libraries - retryhttp[httpx] for httpx only - retryhttp[requests] for requests only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Apache Airflow committer here 👋 . We are using
retryhttpas one of our dependency. We found out that when installed,retryhttpbrings inrequeststoo -- which we don't use it in Airflow project -- which adds 30+mb memory footprint as mentioned in this PR. While the README.md here says we don't need both httpx and requests -- it still lists both as required deps. This PR fixes it.Changes:
Previously, both httpx and requests were always installed even when users only wanted one library. Now users can install only what they need:
retryhttp[all]for both librariesretryhttp[httpx]for httpx onlyretryhttp[requests]for requests only