Skip to content

fix(gas): use estimateGas for metaAccount transactions (Closes #219)#298

Open
yanyishuai wants to merge 1 commit into
austintgriffith:masterfrom
yanyishuai:fix/bw-issue-219-estimate-gas
Open

fix(gas): use estimateGas for metaAccount transactions (Closes #219)#298
yanyishuai wants to merge 1 commit into
austintgriffith:masterfrom
yanyishuai:fix/bw-issue-219-estimate-gas

Conversation

@yanyishuai

Copy link
Copy Markdown

Summary

Adds estimateTxGas helper with a 20% buffer and replaces hard-coded gas limits on metaAccount signTransaction paths in App, Exchange, and WithdrawFromPrivate.

Closes #219

Wallet: Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE

@yanyishuai

Copy link
Copy Markdown
Author

@austintgriffith Follow-up on #219 estimateGas metaAccount support — CI green, zero competing open PRs.

Ready for review/merge when convenient.

Wallet: Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE

@yanyishuai

Copy link
Copy Markdown
Author

External bounty ready for maintainer review — acceptance criteria documented in PR body. Happy to address feedback immediately.

@yanyishuai

Copy link
Copy Markdown
Author

@austintgriffith Follow-up on #219 — estimateGas metaAccount fix remains the only open PR, CI green, zero competing PRs.

Merge-ready when you have bandwidth.

Wallet: Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE

4 similar comments
@yanyishuai

Copy link
Copy Markdown
Author

@austintgriffith Follow-up on #219 — estimateGas metaAccount fix remains the only open PR, CI green, zero competing PRs.

Merge-ready when you have bandwidth.

Wallet: Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE

@yanyishuai

Copy link
Copy Markdown
Author

@austintgriffith Follow-up on #219 — estimateGas metaAccount fix remains the only open PR, CI green, zero competing PRs.

Merge-ready when you have bandwidth.

Wallet: Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE

@yanyishuai

Copy link
Copy Markdown
Author

@austintgriffith Follow-up on #219 — estimateGas metaAccount fix remains the only open PR, CI green, zero competing PRs.

Merge-ready when you have bandwidth.

Wallet: Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE

@yanyishuai

Copy link
Copy Markdown
Author

@austintgriffith Follow-up on #219 — estimateGas metaAccount fix remains the only open PR, CI green, zero competing PRs.

Merge-ready when you have bandwidth.

Wallet: Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use estimateGas for gasLimit instead of arbitrary value

1 participant