Skip to content

feat: react-router extract (Fixes #215) #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rovidev95 wants to merge 7 commits into
base: rim
Choose a base branch
from
Open

feat: react-router extract (Fixes #215) #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
286a266
Migrate Footer and BottomLinks to rimble-ui; xDAI orange theme primary
rovidev95 Jul 2, 2026
776df94
rimble-ui: migrate ShareLink, CashOut, BurnWallet, Receipt, SendByScan
rovidev95 Jul 2, 2026
a4d20cb
rimble-ui: migrate Vendor, Admin, Vendors, RecentTransactions, Advanc…
rovidev95 Jul 2, 2026
4fc723d
rimble-ui: migrate History chat form and action bar
rovidev95 Jul 2, 2026
4274b05
rimble-ui: complete Exchange migration, remove Bootstrap dependency
rovidev95 Jul 2, 2026
b319305
fix: incognito UX and QR scan without reload (Fixes #170, Fixes #200)
rovidev95 Jul 2, 2026
56cf79c
feat: extract react-router-dom from PR #194 (Fixes #215)
rovidev95 Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions docs/ROUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# React Router integration (#215)

Extracted from [dmihal/burner-wallet#194](https://github.com/austintgriffith/burner-wallet/pull/194) **without** `config.js` or `TransactionStore`.

## Architecture

- `src/Container.js` — `BrowserRouter` + `I18nextProvider`
- `src/index.js` — mounts `Container` instead of `App`
- `src/App.js` — wrapped with `withRouter`; navigation via `history.push`

## URL → view mapping

`resolveViewFromPath()` maps paths like `/exchange`, `/send_to_address`, and legacy send URLs (`/0x…;amount`) to the existing view switch. Special cold-start URLs (private keys, `/pk#…`) remain handled by `applyPathFromUrl()`.

## Not included (by design)

- `src/config.js` — hostname config stays in `App.js`
- `src/contexts/TransactionStore.js` — localStorage tx parsing unchanged

A future PR can replace the `switch(view)` block with `<Switch>` / `<Route>` components as in #194.
Loading