Completely revert expr.cc to gcc-12.2.0 upstream #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Good point. Still trying to figure this out some more. It looks like the code in question is not being hit any more, but on the other hand, I do think it should take PUSH_ROUNDING into account if it is ever invoked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking into #232 I reverted expr.cc back to the upstream gcc 12.2.0. This removed the
HACKbut also made another slight change regardingPUSH_ROUNDING.Now that the hack is gone, you might want to consider this change as well. See https://github.com/gcc-mirror/gcc/blob/releases/gcc-12/gcc/expr.cc#L4430-L4435 for context.