Changing duplicate {yourApiIdentifier} value when downloaded as sample app from Quickstarts #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchang16-auth
changed the title
daniellercole
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, this line in api-server.js is:
But when the React sample app is downloaded from the Quickstarts (both Dashboard and from auth0.com/docs) and the user does not have an API created, this line in api-server.js becomes:
This is because
'{API_IDENTIFIER}'is being replaced with'{yourApiIdentifier}'when downloaded as a sample app.Note: this was happening even prior to the changes made in #382, so that PR did not create this text replacing.
Changes
In this PR, we changed
['{yourApiIdentifier}', '{API_IDENTIFIER}']toauthConfig.authorizationParams.audience === '{API_IDENTIFIER}'to remove this duplicated string from happening. This way, it still satisfies both use cases:'{API_IDENTIFIER}'is used when a user downloads the sample app straight from Github'{yourApiIdentifier}'is used when a user downloads the sample app from a Quickstart