-
Notifications
You must be signed in to change notification settings - Fork 241
SDK-5915 address git hub issue 872 #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@NandanPrabhu have you tested with a separate Carthage app that it works correctly? Also with a Cocoapods app? Please also update the instructions in the CONTRIBUTING.md file because now the last step is no longer necessary: https://github.com/auth0/Auth0.swift/blob/master/CONTRIBUTING.md?plain=1#L13 |
Auth0.xcodeproj/project.pbxproj
Outdated
); | ||
runOnlyForDeploymentPostprocessing = 0; | ||
}; | ||
5F331AF61D4BB24C00AE4382 /* Frameworks */ = { | ||
isa = PBXFrameworksBuildPhase; | ||
buildActionMask = 2147483647; | ||
files = ( | ||
D41DED152DCA07D100F5B1A4 /* CwlPreconditionTesting in Frameworks */, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is not necessary for tvOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CwlPosixPreconditionTesting
is used instead.
📋 Changes
Addresses #872
Added JWTDecode and SimpleKeychain as submodule dependency to Auth0 framework
Adding Auth0 framework will ensure JWTDecode and SimpleKeychain comes with it as nested dependency
📎 References
🎯 Testing