Skip to content

SDK-5915 address git hub issue 872 #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

NandanPrabhu
Copy link
Contributor

@NandanPrabhu NandanPrabhu commented May 2, 2025

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Addresses #872
Added JWTDecode and SimpleKeychain as submodule dependency to Auth0 framework
Adding Auth0 framework will ensure JWTDecode and SimpleKeychain comes with it as nested dependency

📎 References

🎯 Testing

@NandanPrabhu NandanPrabhu requested a review from a team as a code owner May 2, 2025 06:51
@NandanPrabhu NandanPrabhu changed the title added JWTDecode and SimpleKeychain as submodules in Auth0 SDK-5915 address git hub issue 872 May 6, 2025
@Widcket
Copy link
Contributor

Widcket commented May 8, 2025

@NandanPrabhu have you tested with a separate Carthage app that it works correctly? Also with a Cocoapods app?

Please also update the instructions in the CONTRIBUTING.md file because now the last step is no longer necessary: https://github.com/auth0/Auth0.swift/blob/master/CONTRIBUTING.md?plain=1#L13

);
runOnlyForDeploymentPostprocessing = 0;
};
5F331AF61D4BB24C00AE4382 /* Frameworks */ = {
isa = PBXFrameworksBuildPhase;
buildActionMask = 2147483647;
files = (
D41DED152DCA07D100F5B1A4 /* CwlPreconditionTesting in Frameworks */,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not necessary for tvOS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CwlPosixPreconditionTesting is used instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants