feat(auth): 🔐 Add UserProfile serialization and include in Credentials #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add userProfile to Credentials.toMap() method - Implement toMap() method in UserProfile class - Update existing tests and add new UserProfile tests
Widcket
reviewed
Feb 10, 2025
Widcket
reviewed
Feb 10, 2025
Widcket
reviewed
Feb 10, 2025
Just making sure `email` is not tested as a required property, as the only required property is `sub`.
|
Hi @Rohithgilla12, thanks for your contribution. We really appreciate it; it's carefully done. In order to merge it, we'd need the commits to be verified. |
Widcket
approved these changes
Feb 10, 2025
2 tasks
Widcket
requested changes
Feb 10, 2025
There was a problem hiding this comment.
My bad, just saw that one of the Dart tests is failing: https://github.com/auth0/auth0-flutter/actions/runs/13248920908/job/36989584252?pr=475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
🎯 Testing
Added tests for the updated code and all of the tests pass
