Skip to content

fix: emit authorization_error for too_many_attempts, guard Cordova plugin instantiation, fix SelectInput name prop #2842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankita10119 wants to merge 1 commit into
base: v13
Choose a base branch
from
Open

fix: emit authorization_error for too_many_attempts, guard Cordova plugin instantiation, fix SelectInput name prop #2842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/core/actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,8 @@ function logInError(id, fields, error, localHandler = (_id, _error, _fields, nex
'rule_error',
'lock.unauthorized',
'invalid_user_password',
'login_required'
'login_required',
'too_many_attempts'
];

if (errorCodesThatEmitAuthorizationErrorEvent.indexOf(errorCode) > -1) {
Expand Down
2 changes: 1 addition & 1 deletion src/core/web_api/p2_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class Auth0APIClient {
responseMode: opts.responseMode,
responseType: opts.responseType,
leeway: opts.leeway || 60,
plugins: opts.plugins || [new CordovaAuth0Plugin()],
plugins: opts.plugins || (typeof CordovaAuth0Plugin === 'function' ? [new CordovaAuth0Plugin()] : []),
overrides: webAuthOverrides(opts.overrides),
_sendTelemetry: opts._sendTelemetry === false ? false : true,
_telemetryInfo: telemetry,
Expand Down
2 changes: 1 addition & 1 deletion src/ui/input/select_input.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default class SelectInput extends React.Component {
if (!label) className += ' auth0-lock-input-with-placeholder';

return (
<InputWrap focused={focused} isValid={isValid} name="location" icon={icon}>
<InputWrap focused={focused} isValid={isValid} name={name} icon={icon}>

@gyaneshgouraw-okta gyaneshgouraw-okta Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a unit test for this change.

<input
id={`${lockId}-${name}`}
type="button"
Expand Down
Loading