Skip to content

feature/conditionally update session handleAccessToken #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Apr 11, 2025

only update session if tokenSet has changed in handleAccessToken route handler. This conditional logic is present in getAccessToken() present in client.ts but absent in it's route couterpart in auth-client.ts

…e handler. This conditional logic is present in getAccessToken() present in client.ts but absent in it's route couterpart in auth-client.ts
@tusharpandey13 tusharpandey13 requested a review from a team as a code owner April 11, 2025 13:36
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.46%. Comparing base (dbfd502) to head (b216c0d).

Files with missing lines Patch % Lines
src/server/auth-client.ts 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2054      +/-   ##
==========================================
- Coverage   78.47%   78.46%   -0.01%     
==========================================
  Files          21       21              
  Lines        1909     1913       +4     
  Branches      307      310       +3     
==========================================
+ Hits         1498     1501       +3     
  Misses        405      405              
- Partials        6        7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants