Skip to content

Fix Missing idToken during Session Migration from v3 to v4 #2116 #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

KentoMoriwaki
Copy link
Contributor

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

  • I changed convertFromLegacy function to handle idToken and updated related specs.

📎 References

🎯 Testing

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (98785c2) to head (b434dc4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2120   +/-   ##
=======================================
  Coverage   82.48%   82.49%           
=======================================
  Files          21       21           
  Lines        2027     2028    +1     
  Branches      356      357    +1     
=======================================
+ Hits         1672     1673    +1     
  Misses        348      348           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frederikprijck
Copy link
Member

Thanks for the PR. If you can ensure the commits are signed, we can look into merging this PR.

@KentoMoriwaki
Copy link
Contributor Author

All commits are now signed ✔️
Please let me know if there’s anything else I should adjust. Thanks for reviewing!

@tusharpandey13 tusharpandey13 merged commit 0bfbe1f into auth0:main May 30, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants