fix: update transaction cookie deletion to clear all cookies on succe… #2464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
This PR fixes the transaction cookie accumulation issue by calling
deleteAllinhandleCallbackupon successful authentication.Problem:
In v4, transaction cookies (
__txn_*) accumulate over time as users navigate the app while unauthenticated. This eventually causes 431 errors due to request header size limits.Solution:
handleCallbackto calltransactionStore.deleteAll()instead oftransactionStore.delete(state)after successful authenticationdeleteAllcall inhandleLogoutChanged files:
src/server/auth-client.ts: Replacedelete(state)withdeleteAll()inhandleCallbacksrc/server/redundant-txn-cookie-deletion.test.ts: Update test to verify all transaction cookies are deleted on success📎 References
deleteAlltohandleLogout🎯 Testing
Unit tests:
redundant-txn-cookie-deletion.test.tsto verify that all transaction cookies are deleted after successful callbackManual testing (verified locally):
__txn_*cookies)__txn_*cookies were cleared from the browser