[draft] [feat]: template for limit session count#23
Conversation
Bringing the session limit count template written by Amin (https://github.com/abbaspour/actions-gallery/blob/main/post-login/session-count/limit-session-count.js)
Removed Todos
|
I would consider using session.revoke instead of access.deny for when the count is > MAX_SESSION. Instead of
While both will deny the user authentication, using access.deny won't invalidate the session and if the user clicks login again, he will be redirected straight to the same error page. This UX can be confusing for the user. Using session.revoke, when the user clicks login, credentails will be asked again |
addressing PR feedback
thanks! i've updated it. Small note, also changed to |
Changes
Adding a template for limiting session counts as defined in this repo:
https://github.com/abbaspour/actions-gallery/blob/main/post-login/session-count/limit-session-count.js
References
https://github.com/abbaspour/actions-gallery/blob/main/post-login/session-count/limit-session-count.js
Checklist
main