fix: improve consistency and clarity in Simple Domain Allow List POST_LOGIN template#30
Open
snocchy wants to merge 3 commits into
Open
fix: improve consistency and clarity in Simple Domain Allow List POST_LOGIN template#30snocchy wants to merge 3 commits into
snocchy wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves code consistency and clarity in
simple-domain-allowlist-POST_LOGINtemplate:api.access.deny()taking a seconduserMessageparameter. This parameter applies to pre-user-registration Actions trigger, not post-login.returnstatement for consistency. If the lack ofreturnwas intentional, please let me know.return api.access.deny()statements into distinct lines to clarify the intent of each operation. The return value ofonExecutePostLoginseems to have no meaning according to the sample codes in the documentation.References
We discussed this internally, so I don’t have a public link. I thought it would be faster to just write the code and open a PR rather than start a public discussion.
Testing
Steps to Reproduce
Checklist
main