feat: integrated identifiers in theme and country_codes in tenant#1638
Merged
Conversation
bkiran6398
reviewed
Jul 7, 2026
| countryCodes.List = *list | ||
| } | ||
|
|
||
| if countryCodes.Mode == "" { |
Contributor
There was a problem hiding this comment.
Considering mode is required and (allow, deny) are the only allowed values. This check is redundant.
bkiran6398
reviewed
Jul 7, 2026
| } | ||
|
|
||
| config := data.GetRawConfig().GetAttr("country_codes") | ||
| if config.IsNull() { |
Contributor
There was a problem hiding this comment.
A minor cosmetic update can be done to combine both returns in one line:
return config.IsNull() || config.LengthInt() == 0
bkiran6398
reviewed
Jul 7, 2026
| MaxItems: 1, | ||
| Optional: true, | ||
| Computed: true, | ||
| Description: "Configuration for identifier input display settings. Requires the identifier input feature flag to be enabled on the tenant.", |
Contributor
There was a problem hiding this comment.
Please mention that "once added, identifiers can only be updated but not removed".
KartikJha
force-pushed
the
DXCDT-1982/auth0-identifier-country-code
branch
from
July 7, 2026 11:48
0832e20 to
c1c51a7
Compare
bkiran6398
previously approved these changes
Jul 8, 2026
KartikJha
changed the title
Contributor
Author
|
@bkiran6398 as discussed we will be sending this in the next release. |
KartikJha
marked this pull request as draft
July 9, 2026 09:52
KartikJha
marked this pull request as ready for review
July 22, 2026 19:04
KartikJha
changed the title
KartikJha
force-pushed
the
DXCDT-1982/auth0-identifier-country-code
branch
from
July 22, 2026 19:30
7436632 to
4f70f13
Compare
bkiran6398
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
identifierstoauth0_branding_themeandcountry_codestoauth0_tenant🔧 Changes
resource/auth0_branding_theme(and corresponding data source) – Added a newidentifiersblock for configuring identifier input display settings:login_display(unified/separate),otp_autocomplete(bool), and a nestedphone_displayblock (formatting:international/regional,masking:mask_digits/hide_country_code/show_all). This requires the identifier input feature flag to be enabled on the tenant; when the flag is first enabled, existing themes will pick up the API's default values in state on the next refresh with no plan diff.resource/auth0_tenant(and corresponding data source) – Added a newcountry_codesblock for configuring phone identifier country code allow/deny filtering:list(a set of ISO 3166-1 alpha-2 codes, validated against^[A-Z]{2}$) andmode(allow/deny). This requires the country codes feature flag to be enabled on the tenant. Removing the block from configuration disables filtering (handled via the existing nullable-fields mechanism, following the same explicit-null pattern used elsewhere in the tenant resource).github.com/auth0/go-auth0tov1.44.1-0.20260706143633-e668df8e2b46to pick up the newBrandingThemeIdentifiers/BrandingThemePhoneDisplayandTenantCountryCodesSDK types.auth0_branding_themeandauth0_tenantto document the new blocks.📚 References
🔬 Testing
internal/auth0/branding/expand_test.go,internal/auth0/branding/flatten_test.go– coveridentifiers/phone_displayexpand and flatten, including nil/empty cases.internal/auth0/tenant/expand_test.go,internal/auth0/tenant/flatten_test.go– covercountry_codesexpand/flatten and the explicit-null handling when the block is removed.TestAccBrandingThemeIdentifiers(internal/auth0/branding/resource_theme_test.go,test/data/recordings/TestAccBrandingThemeIdentifiers.yaml)TestAccTenant_CountryCodes(internal/auth0/tenant/resource_test.go,test/data/recordings/TestAccTenant_CountryCodes.yaml)📝 Checklist