fix!: add required /v2 module path suffix - #24
Merged
Conversation
This module has been tagged v2.x since v2.0.0, but go.mod never added the /v2 suffix Go's module versioning rules require for major version 2+. The practical effect: no v2.x tag has ever been resolvable via the standard toolchain - `go get github.com/authorizerdev/authorizer-go@v2.x.x` fails with "module contains a go.mod file, so module path must match major version". Confirmed against the module proxy before this fix. BREAKING CHANGE: import path changes from github.com/authorizerdev/authorizer-go to github.com/authorizerdev/authorizer-go/v2. Existing v2.x import lines were never actually resolvable, so this doesn't newly break anyone who had a working build - it makes v2.x installable for the first time. Verified: go build/vet/gofmt clean; full go test ./... (including the live integration suite across graphql/rest/grpc, public+admin) passes against a locally built authorizer:localmain image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This module has been tagged v2.x since v2.0.0, but
go.modnever added the/v2suffix Go's module versioning rules require for major version 2+. Confirmed via the module proxy: no v2.x tag has ever actually resolved for a consumer running a plaingo get github.com/authorizerdev/authorizer-go@v2.x.x— it fails with "module contains a go.mod file, so module path must match major version".What changed
go.mod:module github.com/authorizerdev/authorizer-go→module github.com/authorizerdev/authorizer-go/v2test/,examples/) updated to the new import path.Breaking, but not newly breaking anyone with a working build — v2.x import lines were never resolvable in the first place, so this makes v2.x installable for the first time rather than changing behavior for anyone currently depending on it successfully.
Test plan
go build/go vet/gofmtcleango test ./...— including the live integration suite across graphql/rest/grpc, public+admin — passes against a locally builtauthorizer:localmainimage