Update win32's constants#133
Open
calvinchengx wants to merge 7 commits into
Open
Conversation
|
drunisa007 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Use LAContext localizedReason for prompts
macOS implementation moved to the SwiftPM layout (Sources/biometric_storage/) with Package.swift (macOS 10.14, FlutterFramework dependency); podspec source_files repointed so SPM and CocoaPods share one source tree. The iOS side (mixed ObjC+Swift registration shim) stays on CocoaPods — SPM cannot build mixed-language targets.
Add Swift Package Manager support (macOS)
Folds the ObjC registration shim (BiometricStoragePlugin.h/.m) into the Swift plugin class, renamed SwiftBiometricStoragePlugin -> BiometricStoragePlugin with @objc(BiometricStoragePlugin), so the iOS implementation is a single pure-Swift SPM target (SPM cannot build mixed ObjC+Swift). Moves sources to Sources/biometric_storage/, adds Package.swift, drops the now-empty public_header_files, repoints the podspec.
…al file (#4) The iOS Sources' BiometricStorageImpl.swift was a symlink to ../../macos/Classes/BiometricStorageImpl.swift. The macOS SPM migration moved that file out of macos/Classes/, so the symlink dangled and SPM failed with 'Cannot find BiometricStorageImpl in scope' (CocoaPods tolerated the old layout; SPM does not). Replace it with a real copy of the shared impl (imports LocalAuthentication; no platform-specific code). macOS keeps its own real copy. Validated by flutter build ios on the hellohq app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.