Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete_user and delete_user_authenticator method #22

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion authsignal/client.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import decimal
import jwt
from authsignal.version import VERSION

import humps
Expand Down Expand Up @@ -150,6 +149,46 @@ def get_user(self, user_id, redirect_url=None, path=None):
except requests.exceptions.RequestException as e:
raise ApiException(str(e), path) from e

def delete_user(self, user_id):
_assert_non_empty_unicode(user_id, 'user_id')

user_id = urllib.parse.quote(user_id)
path = f'{self.url}/v1/users/{user_id}'
headers = self._default_headers()

try:
response = self.session.delete(
path,
auth=requests.auth.HTTPBasicAuth(self.api_key, ''),
headers=headers,
timeout=self.timeout
)
response.raise_for_status()
return humps.decamelize(response.json())
except requests.exceptions.RequestException as e:
raise ApiException(str(e), path) from e

def delete_user_authenticator(self, user_id: str, user_authenticator_id: str) -> Dict[str, Any]:
_assert_non_empty_unicode(user_id, 'user_id')
_assert_non_empty_unicode(user_authenticator_id, 'user_authenticator_id')

user_id = urllib.parse.quote(user_id)
user_authenticator_id = urllib.parse.quote(user_authenticator_id)
path = f'{self.url}/v1/users/{user_id}/authenticators/{user_authenticator_id}'
headers = self._default_headers()

try:
response = self.session.delete(
path,
auth=requests.auth.HTTPBasicAuth(self.api_key, ''),
headers=headers,
timeout=self.timeout
)
response.raise_for_status()
return humps.decamelize(response.json())
except requests.exceptions.RequestException as e:
raise ApiException(str(e), path) from e

def update_user(self, user_id, data):
user_id = urllib.parse.quote(user_id)

Expand Down
26 changes: 26 additions & 0 deletions authsignal/client_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,15 @@ def test_get_action(self):
self.assertEqual(response["state"], "ALLOW")
self.assertEqual(response["state_updated_at"], "2022-07-25T03:19:00.316Z")

@responses.activate
def test_delete_user(self):
responses.add(responses.DELETE, f"{base_url}/users/1234",
json={"success": True}, status=200)

response = self.authsignal_client.delete_user(user_id="1234")

self.assertEqual(response["success"], True)

@responses.activate
def test_update_user(self):
user_id = "1234"
Expand Down Expand Up @@ -142,6 +151,23 @@ def test_it_returns_success_if_user_id_is_correct(self):
self.assertEqual(response["state"], "CHALLENGE_SUCCEEDED")
self.assertTrue(response["is_valid"])


@responses.activate
def test_delete_user_authenticator(self):
self.authsignal_client = client.Client(api_key='test_api_key')
user_id = 'test_user'
user_authenticator_id = 'test_authenticator'
expected_url = f'{self.authsignal_client.url}/v1/users/{user_id}/authenticators/{user_authenticator_id}'

responses.add(responses.DELETE, expected_url, json={"success": True}, status=200)

response = self.authsignal_client.delete_user_authenticator(user_id, user_authenticator_id)

self.assertEqual(response["success"], True)
self.assertEqual(len(responses.calls), 1)
self.assertEqual(responses.calls[0].request.url, expected_url)
self.assertEqual(responses.calls[0].response.status_code, 200)

@responses.activate
def test_it_returns_success_false_if_user_id_is_incorrect(self):
responses.add(responses.POST, f"{base_challenge_url}/validate",
Expand Down
2 changes: 1 addition & 1 deletion authsignal/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
VERSION = '2.0.4'
VERSION = '2.0.5'
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "authsignal"
version = "2.0.4"
version = "2.0.5"
description = "Authsignal Python SDK for Passwordless Step Up Authentication"
authors = ["justinsoong <[email protected]>"]
license = "MIT"
Expand Down
Loading