Run tests against Node 22 #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
force-pushed
the
run-tests-node-22
branch
from
e9b21bb to
ecf50a7
Compare
alecmerdler
approved these changes
Feb 6, 2025
Contributor
|
@tstirrat15 did the new build actually run ? |
Contributor
Author
|
no 🤦 paths-filter failed. i wonder if it's worth getting rid of that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
Description
Node 22 is the current LTS, and odd-numbered node versions are never LTS. We're probably okay to run only against even-numbered versions.
Changes
Testing
See that tests pass with new matrix