Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Corey-T1000
left a comment
Corey-T1000
left a comment
There was a problem hiding this comment.
Review
Clean PR — good hardening of the suggestion workflow and consistent YAML lint fixes.
Concurrency & timeout
Concurrency with cancel-in-progress: false is the right call — parallel issues can still run, and in-flight doc generation won't get killed. 30-minute timeout for a 50-turn Claude session is reasonable.
Failure/timeout notifications
Solid defensive pattern with continue-on-error: true and ::warning:: fallback. One small nit: the "Notify on timeout" step triggers on cancelled(), and the title says "Documentation Workflow Timed Out" — but cancellation can happen for other reasons (manual cancel). The body correctly says "cancelled or timed out" but the title leans toward timeout only. Minor.
RESTRICTIONS block
Good improvement over the previous loose guidance. Explicitly listing allowed/forbidden paths reduces the chance of Claude modifying workflow/config files.
Minor nit
cla.yaml now has both "on": (quoted) and the # yamllint disable-line rule:truthy comment. Either one solves the truthy rule — having both is redundant. Could drop the comment.
LGTM — approve with the two minor nits above.
- Add concurrency group to prevent parallel runs on same issue - Add 30-minute timeout to Claude Code step - Add failure and timeout notification steps - Update security comment formatting - Clarify restrictions in prompt Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
samkim
force-pushed
the
suggestion-workflow-improvements
branch
from
a02bf7d to
711ebce
Compare
|
Preview deployment status for this pull request.
|
2 participants
Picked select improvements from this PR (#487)