improvements to context severing #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
reviewed
May 1, 2025
vroldanbet
force-pushed
the
context-severing-changes
branch
from
e93789a to
284beed
Compare
This helps making sure that all the values stuffed in the context are retained without having to recreate all of it manually
this means we keep all the different components injected in the context intact, and we only change the cancelation propagation.
vroldanbet
force-pushed
the
context-severing-changes
branch
from
284beed to
5bfcb36
Compare
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (74.41%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2370 +/- ##
==========================================
- Coverage 75.52% 74.41% -1.11%
==========================================
Files 479 479
Lines 52224 52215 -9
==========================================
- Hits 39438 38851 -587
- Misses 10173 10791 +618
+ Partials 2613 2573 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ecordell
approved these changes
Jun 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements to the use of context-severing strategies in the codebase