Skip to content

Add development containers support #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

katallaxie
Copy link

@katallaxie katallaxie commented May 2, 2025

Describe your changes

The changes here add support for development containers to make it easy to spin-up a development environment.

To test this works with most of the tools the go run cmd/spicedb/main.go was run to run the server locally and mage -l.

@katallaxie katallaxie requested a review from a team as a code owner May 2, 2025 06:07
@github-actions github-actions bot added the area/docs Affects docs or metadata (e.g. README) label May 2, 2025
@katallaxie
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@katallaxie katallaxie force-pushed the devcontainers branch 2 times, most recently from f6889fa to 9155b04 Compare May 2, 2025 08:32
vroldanbet
vroldanbet previously approved these changes May 2, 2025
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! LGTM!

"customizations": {
"vscode": {
"extensions": [
"golang.go"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe worth adding the spicedb extension? https://marketplace.visualstudio.com/items?itemName=authzed.spicedb-vscode

Also perhaps docker extension?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to do so. I wanted to keep the surface slim, but these are helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Affects docs or metadata (e.g. README)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants