-
Notifications
You must be signed in to change notification settings - Fork 311
Add development containers support #2379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I have read the CLA Document and I hereby sign the CLA |
f6889fa
to
9155b04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution! LGTM!
.devcontainer/devcontainer.json
Outdated
"customizations": { | ||
"vscode": { | ||
"extensions": [ | ||
"golang.go" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe worth adding the spicedb extension? https://marketplace.visualstudio.com/items?itemName=authzed.spicedb-vscode
Also perhaps docker extension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to do so. I wanted to keep the surface slim, but these are helpful.
Describe your changes
The changes here add support for development containers to make it easy to spin-up a development environment.
To test this works with most of the tools the
go run cmd/spicedb/main.go
was run to run the server locally andmage -l
.