Add perfinsights middleware which writes the latency of API calls #2383
+712
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/cli
vroldanbet
reviewed
May 8, 2025
| } | ||
|
|
||
| // UnaryServerInterceptor returns a gRPC server-side interceptor that provides reporting for Unary RPCs. | ||
| func UnaryServerInterceptor(isEnabled bool) grpc.UnaryServerInterceptor { |
There was a problem hiding this comment.
Please create a unit test that mounts this interceptor over a gRPC server and confirms a request generates the metrics
josephschorr
force-pushed
the
perf-insights
branch
from
585adef to
40b86cf
Compare
|
Updated |
miparnisari
reviewed
May 8, 2025
vroldanbet
previously approved these changes
May 9, 2025
github-actions
bot
added
the
area/tooling
to a new native histogram bucket Should help users determine top-line API latency
josephschorr
force-pushed
the
perf-insights
branch
from
40b86cf to
8b51bb8
Compare
vroldanbet
approved these changes
May 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to a new native histogram bucket
Should help users determine top-line API latency