Skip to content

feat(web): add generic webhook as notification service option#170

Merged
s0up4200 merged 1 commit into
developfrom
fix/add-generic-webhook-notification-option
Jan 24, 2026
Merged

feat(web): add generic webhook as notification service option#170
s0up4200 merged 1 commit into
developfrom
fix/add-generic-webhook-notification-option

Conversation

@s0up4200

@s0up4200 s0up4200 commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds "Generic Webhook" as a selectable notification service type in the notification settings UI
  • Uses the Shoutrrr generic:// URL scheme which was already supported by the backend but missing from the frontend dropdown

Closes #125

Test plan

  • Navigate to Settings > Notifications
  • Create a new notification channel
  • Verify "Generic Webhook" appears in the service type dropdown
  • Verify the example URL shows generic://HOSTNAME/PATH?template=json
  • Test sending a notification to a generic webhook endpoint

Summary by CodeRabbit

Release Notes

  • New Features

    • Added Generic Webhook as a new notification service option.
  • Bug Fixes

    • Corrected the Pushover service configuration example format.

✏️ Tip: You can customize this high-level summary in your review settings.

@s0up4200

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jan 24, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Jan 24, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Added Generic Webhook as a selectable notification service option in the UI notification settings to match shoutrrr's backend support. Updated the Pushover service example URL format by removing an extraneous colon in the token portion.

Changes

Cohort / File(s) Summary
Notification Services Configuration
web/src/api/notifications.ts
Added Generic Webhook service option (value: "generic", label: "Generic Webhook", example: "generic://HOSTNAME/PATH?template=json"). Fixed Pushover example format by removing leading colon in token portion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A webhook generic, now ready to hop,
Through notification tunnels without any stop,
Pushover's format cleaned up with care,
Local webhooks answered—fair and square! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a generic webhook notification service option to the web UI.
Linked Issues check ✅ Passed The pull request successfully addresses issue #125 by adding 'Generic Webhook' as a selectable service type in the notification settings dropdown.
Out of Scope Changes check ✅ Passed All changes are in-scope: the new Generic Webhook entry and the Pushover example fix are directly related to notification service configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

@s0up4200 s0up4200 merged commit 1a351d1 into develop Jan 24, 2026
10 checks passed
@s0up4200 s0up4200 deleted the fix/add-generic-webhook-notification-option branch January 24, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Generic Webhook as an option on Notification Settings

1 participant