feat(packetloss): add option to enable DNS resolution in MTR tests#172
Merged
Conversation
Add mtr_enable_dns config option to show hostnames instead of IP addresses in MTR traceroute results. Disabled by default to preserve current behavior. Configurable via: - config.toml: [packetloss] mtr_enable_dns = true - Environment variable: NETRONOME__PACKETLOSS_MTR_ENABLE_DNS=true Closes #160
📝 WalkthroughWalkthroughThis PR adds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mtr_enable_dnsconfig option to the[packetloss]section that controls whether MTR tests resolve hostnames or show raw IP addresses--no-dns(Unix) /-n(Windows) flags from MTR commands so hostnames likeone.one.one.oneare shown instead of1.1.1.1mtr_enable_dns = true) or environment variable (NETRONOME__PACKETLOSS_MTR_ENABLE_DNS=true)Closes #160
Test plan
go build ./...compiles without errorsgo test ./...all tests passmtr_enable_dns = false(default) and verify MTR results show IP addresses onlymtr_enable_dns = trueand verify MTR results show resolved hostnamesNETRONOME__PACKETLOSS_MTR_ENABLE_DNS=trueenv var and verify it overrides the config filegenerate-configand verify the new option appears in the generated configSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.