feat: add Docker image publishing to GHCR - #72
Conversation
Co-authored-by: Devin Buhl <onedr0p@users.noreply.github.com>
Co-authored-by: Devin Buhl <onedr0p@users.noreply.github.com>
There was a problem hiding this comment.
couldn't we use goreleaser-pro here or is it only enabled in autobrr/autobrr? 🤔
we should probably also use --snapshot for Run GoReleaser build and --parallelism 5 for Run GoReleaser build and publish tags.
tqm/.github/workflows/build.yml
Lines 75 to 93 in ed3b8fb
last thing: it would be nice to have it actually return a version other than main in the built image, example here from my seasonpackarr 😅
that would result in 1.15.0-dev8 for example
https://github.com/nuxencs/seasonpackarr/blob/16291f2b3ad4f88e05535acdf11465d8141390ef/.github/workflows/release.yml#L140-L178
- Add --snapshot flag to PR builds for proper snapshot releases - Add --parallelism 5 to tag releases for faster builds - Implement dynamic version generation for main branch builds (e.g., v1.15.0-dev8) - Update Docker metadata to use generated versions for development builds
|
Talked to Nuxen on Discord, re goreleaser-pro. Its available org wide, but no benefit from using as long as we dont use the pro features. |
|
This does not run in its current state, and needs more work. Will continue on it in the coming days. |
| RUN mkdir -p /config && \ | ||
| chown nobody:nogroup /config | ||
|
|
||
| WORKDIR /app | ||
| VOLUME /config | ||
|
|
||
| COPY --link --from=app-builder /out/bin/tqm /usr/local/bin/ | ||
|
|
||
| USER nobody:nogroup |
There was a problem hiding this comment.
| RUN mkdir -p /config && \ | |
| chown nobody:nogroup /config | |
| WORKDIR /app | |
| VOLUME /config | |
| COPY --link --from=app-builder /out/bin/tqm /usr/local/bin/ | |
| USER nobody:nogroup | |
| COPY --link --from=app-builder /out/bin/tqm /usr/local/bin/ | |
| USER nobody:nogroup | |
| WORKDIR /config | |
| VOLUME ["/config"] |
This is how I've been building containers over at https://github.com/home-operations/containers
|
|
||
| USER nobody:nogroup | ||
|
|
||
| ENTRYPOINT ["/usr/local/bin/tqm", "--config-dir", "/config"] No newline at end of file |
There was a problem hiding this comment.
| ENTRYPOINT ["/usr/local/bin/tqm", "--config-dir", "/config"] | |
| ENTRYPOINT ["/usr/local/bin/tqm", "--config-dir", "/config"] | |
|
@s0up4200 was there something else we are missing here? With my suggested changes, PR looks good from here. |
|
What is missing is a rework of how the config is loaded.
…On Wed, Aug 13, 2025, 23:44 Devin Buhl ***@***.***> wrote:
*onedr0p* left a comment (autobrr/tqm#72)
<#72 (comment)>
@s0up4200 <https://github.com/s0up4200> was there something else we are
missing here?
—
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSIMLUP3VVMRAYNNUMWE533NOWUXAVCNFSM6AAAAACCBGGWX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBVHEZDOMZRGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@saltydk maybe I'm missing some context but what does that have to do with publishing a container image? |
|
Because it caused a runtime panic.
…On Thu, Aug 14, 2025, 01:38 Devin Buhl ***@***.***> wrote:
*onedr0p* left a comment (autobrr/tqm#72)
<#72 (comment)>
@saltydk <https://github.com/saltydk> maybe I'm missing some context but
what does that have to do with publishing a container image?
—
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSIMLX7KFJEHJIRPIETMZ33NPD5TAVCNFSM6AAAAACCBGGWX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBWGE4DOOJTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I'm running tqm in a custom built image just fine. I still feel like I'm missing context here, there's no open issues or PRs about the issue you just brought up. |
|
It was posted in the discord chat you responded to.
…On Thu, Aug 14, 2025, 01:45 Devin Buhl ***@***.***> wrote:
*onedr0p* left a comment (autobrr/tqm#72)
<#72 (comment)>
I'm running tqm in a custom built image just fine. I still feel like I'm
missing context here, there's no open issues or PRs about the issue you
just brought up.
—
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSIMLU6LCCZGKBX4CH2QFD3NPE25AVCNFSM6AAAAACCBGGWX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCOBWGIYDKOJZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I do remember skimming that but thought the issue was sometime else. Thanks for walking me though it. For the future travelers, the issue is tqm expects the config to be in the user directory and tries to create the path. Line 19 in b72aa68 |
No description provided.