Skip to content

fix(cli): if no dupes are found don't display all search results - #227

Open
wasserrutschentester wants to merge 1 commit into
autobrr:mainfrom
wasserrutschentester:fix/no-dupes
Open

fix(cli): if no dupes are found don't display all search results#227
wasserrutschentester wants to merge 1 commit into
autobrr:mainfrom
wasserrutschentester:fix/no-dupes

Conversation

@wasserrutschentester

@wasserrutschentester wasserrutschentester commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Updated duplicate-result output so only filtered entries are shown.
    • When no filtered entries are available, no entry lines are displayed.

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ef78a23d-bf08-4d40-b370-ffb0bfcbf2c5

📥 Commits

Reviewing files that changed from the base of the PR and between 7496259 and 0f6378e.

📒 Files selected for processing (1)
  • cmd/upbrr/interactive.go
💤 Files with no reviewable changes (1)
  • cmd/upbrr/interactive.go

📝 Walkthrough

Walkthrough

The change removes a fallback in printDupeResult that previously used result.Raw entries when result.Filtered was empty. Now the function only prints entries from result.Filtered, so an empty Filtered list results in no printed entries.

Changes

Dupe Result Printing

Layer / File(s) Summary
Remove Raw fallback
cmd/upbrr/interactive.go
printDupeResult no longer falls back to result.Raw when result.Filtered is empty; it prints only result.Filtered entries.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A hop, a nibble, a tiny cut,
No more Raw fallback in the mut(t)ering hut,
Filtered alone now leads the way,
Simpler code for a brighter day! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: it stops showing all search results when no dupes are found.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Audionut

Audionut commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

After #273 merges, this PR is superseded and should not be rebased mechanically:

  • refactor!: replace Wails with embedded WebUI and durable release workflow API #273 removes the legacy interactive.go, printDupeResult, and writeDupeResult rendering path.
  • Duplicate results now enter the durable workflow through internal/core/workflow_dupes.go. The public TrackerDupeAssessment.Matches projection is built by publicDupeMatches from result.Filtered only; unfiltered result.Raw evidence remains private workflow state.
  • CLI, WebUI, and API clients consume the sanitized Matches projection. A raw-only result with empty Filtered, HasDupes == false, and no matched reason therefore produces no displayed entries, a no_match decision, and no duplicate-review action.
  • Preserve the intentional fallback for genuine duplicate evidence where HasDupes or the typed match result is set even if the tracker returned no filtered entry details.
  • Add a focused internal/core/workflow_dupes_test.go regression with populated Raw and empty Filtered, asserting empty public matches, DupeDecisionNoMatch, and no required action. Composite CLI/API coverage is only needed if that projection behavior changes.

Once #273 is on main, this PR can be closed as superseded rather than carrying its deleted CLI hunk forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants