-
-
Notifications
You must be signed in to change notification settings - Fork 842
Update build to use GitHub Actions #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tween source and test rulesets.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1455 +/- ##
===========================================
- Coverage 78.94% 77.93% -1.01%
===========================================
Files 200 211 +11
Lines 5681 5403 -278
Branches 1145 1148 +3
===========================================
- Hits 4485 4211 -274
+ Misses 699 693 -6
- Partials 497 499 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Just realized I probably need to make the "package/push" dependent on all the steps completing including lint. Let me fix that up. |
Fixed that. I think there's a potential that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just one thought.
I'm not sure why the coverage is lower, but it's likely a difference in reporting and due to some of the minor rename/refactor items here. I'm going to go ahead and merge this in since I want to get past the build challenges and start getting other PRs building using the new system. |
This switches the overall build and release process to be more modernized and use GitHub Actions and MSBuild.
Run the build with
dotnet msbuild ./default.proj
.The original Powershell build was written before the
dotnet
command existed, when it was stilldnx
. The notion ofdotnet test
didn't quite work as expected, the MSBuild support wasn't really cross-platform... it was a long time ago. A lot has evolved since then and it's time to update.develop
) and releases (tags onmaster
withvX.Y.Z
format) will be published to GitHub Packages.master
withvX.Y.Z
format) will be published to NuGet.dotnet format
checking to the build. It isn't part of pre-commit because it seems to want to restore the whole solution just to check one file. We can converge that later if someone figures out how. There are a couple of minor formatting fixes included due to this.global.json
.coverlet.msbuild
package where sometimes the coverage process gets killed mid-gathering.I'll need to update the central
CONTRIBUTING.md
to explain the changes here.I have not been able to actually test the publishing to GitHub Packages or NuGet. It could be that we need to adjust things on the fly the first time we run it. Likely we should do that before converting other repos to this structure.