DOC: Rephrase hash usage for release commits #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR! I think both options are fine really, I won't push functional changes onto main without shipping a release. I'm happy to take the rephrased version though, let's merge this together with the next batch of changes to not create any unnecessary toil for people who do indeed track main. :) |
Member
|
Thank you again! Merged in 30d5315. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to see if it's indeed your recommendation to pin to 551dded as opposed to 2891949?
The latter has the advantage of having a clean intention: being explicit and secure about using the latest release; while the former suggest that something critical has been fixed in
mainthat has not yet release while in fact it was only minor documentation changes that happened.