Skip to content

Add SVG icons for file types: doc, empty, jpg, pdf, and png - #78

Closed
sgimama wants to merge 2 commits into
mainfrom
feature/type-files-icons
Closed

Add SVG icons for file types: doc, empty, jpg, pdf, and png#78
sgimama wants to merge 2 commits into
mainfrom
feature/type-files-icons

Conversation

@sgimama

@sgimama sgimama commented Jun 16, 2026

Copy link
Copy Markdown
Member
  • Added file-doc.svg for document representation.
  • Added file-empty.svg for empty file representation.
  • Added file-jpg.svg for JPEG image representation.
  • Added file-pdf.svg for PDF document representation.
  • Added file-png.svg for PNG image representation.

Please fill in this template

  • Use a meaningful title for the pull request
  • Optimise SVGs before you raise a pull request

Select one of these, and delete the others:

Adding an icon: this will be marked as a patch

  • Give the icon a meaningful name, preferably namespaced eg,
    car-windscreen rather than just windscreen.
  • Add svg to the icons/ folder, and raise the pull request

If moving, renaming or deleting an icon: this will be marked as a minor

  • Give the icon a meaningful name, preferably namespaced eg,
    car-windscreen rather than just windscreen.
  • Describe why the icon was renamed, moved or deleted.
  • If you are renaming an icon, and also adding an icon with the same name
    as the old renamed file. Please raise both of those in a single pull
    request, and annotate the pull request as a breaking change.
  • With an all caps "BREAKING CHANGE" at the bottom of the pull request,
    describe a migration path for this.
BREAKING CHANGE:
IconA is now IconB
IconC no longer exists, please use IconX instead

Note, you don't need to tell us that IconA no longer exists, because of the
rename.


Big icon changes will be marked as a major, but will probably be done manually
in 1 pull request, and versioned accordingly.

- Added file-doc.svg for document representation.
- Added file-empty.svg for empty file representation.
- Added file-jpg.svg for JPEG image representation.
- Added file-pdf.svg for PDF document representation.
- Added file-png.svg for PNG image representation.
@sgimama
sgimama requested a review from a team as a code owner June 16, 2026 14:22
@sgimama sgimama closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant