You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Switches the default embedding model from OpenAI text-embedding-3-small (requires API key) to FastEmbed bge-small-en-v1.5 (runs locally on CPU, no API key).
Reviewed 0 past PRs · 0 relevant decisions found · confidence threshold 0.5
⚠️ Potential conflicts
Removal of Nomic embedding support with name change · confidence: 0.75
The PR removes support for 'nomic-embed-text' model but introduces a new 'nomic-embed-text-v1.5' model via FastEmbed. While the new version offers compatibility, the old model name is no longer supported. Any existing deployments explicitly using 'nomic-embed-text' will break. The factory.py previously had explicit NomicEmbedding class support; this is now consolidated into FastEmbed. Tests were updated, but the breaking change in model naming should be documented clearly.
Dependency restructuring: embedding backends moved to optional dependencies · confidence: 0.85
pyproject.toml shows that 'openai' and 'cohere' packages are moved from base dependencies to optional dependencies ('openai' and 'cohere' extras). However, the factory.py now uses lazy imports (ImportError handling) for these optional packages. This creates a gap: the base 'mergelore-indexer' install will no longer include OpenAI/Cohere support by default, which is a breaking change if users relied on the automatic availability. Tests handle this with try/except for ImportError, but users upgrading may experience runtime failures when requesting these models without the optional extras.
Default embedding model changed from text-embedding-3-small to bge-small-en-v1.5 · confidence: 0.90
The default embedding model is changed from 'text-embedding-3-small' (OpenAI, requires API key) to 'bge-small-en-v1.5' (FastEmbed local). While this simplifies the default deployment (no API key needed), it is a breaking change for any existing deployments that relied on OpenAI embeddings without explicitly setting MERGELORE_EMBED_MODEL. Vector dimensions also change (1536 → 384), which may affect downstream vector search compatibility if not re-indexed.
Test refactoring reduces validation coverage for embed model selection (confidence: 0.65): In test_embed_factory.py, tests for OpenAI and Cohere providers now accept both ValueError and ImportError. This relaxes validation specificity: previously, tests explicitly verified that missing API keys raised ValueError with specific messages. Now, ImportError (from lazy import) is also accepted, making it harder to distinguish between 'API key missing' vs 'optional package not installed'. While functionally acceptable, it reduces precision in error reporting and testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the default embedding model from OpenAI text-embedding-3-small (requires API key) to FastEmbed bge-small-en-v1.5 (runs locally on CPU, no API key).
This simplifies Tier 2 setup from 4 secrets to 2:
OpenAI and Cohere remain available as optional plugins via
pip install mergelore-indexer[openai]ormergelore-indexer[cohere].Changes
Embedding models