Fix: Handle empty _nameToDisplay_ on first run to enable P2P testing #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first launch, nameToDisplay resolves to "" instead of the expected “???”. This breaks the app’s flow, making P2P functionality untestable.
This patch adds a check for .isEmpty and ensures editNamePopoverShown opens when the value is empty. With this change, the app becomes usable out of the box for testing.
My guess is the library doesn't "load a default value" but rather just "".
Not claiming this is the definitive fix, but it gets things working for now.
Pictured below is what the app looks like on first boot.

And here are the logs when you attempt to turn on the P2P functionality: