Multiple counter increments in the same change produce the wrong result #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iling-counter-test
|
Marking this as needing to be fixed before 1.0 stable. |
ept
changed the title
echarles
pushed a commit
to datalayer-externals/automerge-classic-arch
that referenced
this pull request
Feb 16, 2023
Add increment observation for observer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lukas found a issue and wrote a test for it - I think this may be a result of taking out the op coalescing frontend but we had no tests catching it.
Perhaps we need to put the op coalescing back in or make the backend properly handle multiple increments in the same change.