re-use prosemirror basic schema and fix addIsAmgBlockAttr #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I actually have a lot of changes in flight on this particular part of the codebase right now as I do the work to enable user provided schemas. Is this blocking you or do you mind waiting a few days whilst I whip that into shape? |
|
Not blocking me! Just playing around with automerge-prosemirror. I do have a custom schema that I want to bring & want to try to integrate a cloudflare KV store persistence for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things
schema.tsto re-useprosemirror-schema-basicandprosemirror-schema-listfor the base schemaaddIsAmgBlockAttrto create a new copy instead of modifying map; this is important when re-using an existingSchemasuch as when letting users bring their own genericSchema