Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automerge, re-add save decision #21

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ tokio = ["dep:tokio", "dep:tokio-util"]
tokio-tungstenite = ["tokio", "dep:tokio-tungstenite", "dep:tungstenite"]

[dependencies]
automerge = { version = "0.4.1" }
automerge = { version = "0.5.0" }
uuid = { version = "1.2.2"}
crossbeam-channel = { version = "0.5.8" }
parking_lot = { version = "0.12.1" }
Expand Down Expand Up @@ -53,4 +53,4 @@ test-log = "0.2.12"
env_logger = "0.10.0"
tracing-subscriber = "0.3.17"
itertools = "0.11.0"
autosurgeon = "0.7.1"
autosurgeon = "0.8.0"
39 changes: 28 additions & 11 deletions src/repo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,8 @@ pub(crate) struct DocumentInfo {
/// Counter of patches since last save,
/// used to make decisions about full or incemental saves.
patches_since_last_save: usize,
/// Last heads obtained from the automerge doc.
last_heads: Vec<ChangeHash>,
}

impl DocumentInfo {
Expand All @@ -566,13 +568,18 @@ impl DocumentInfo {
document: Arc<RwLock<SharedDocument>>,
handle_count: Arc<AtomicUsize>,
) -> Self {
let last_heads = {
let doc = document.read();
doc.automerge.get_heads()
};
DocumentInfo {
state,
document,
handle_count,
sync_states: Default::default(),
change_observers: Default::default(),
patches_since_last_save: 0,
last_heads,
}
}

Expand Down Expand Up @@ -688,8 +695,14 @@ impl DocumentInfo {
/// Count patches since last save,
/// returns whether there were any.
fn note_changes(&mut self) -> bool {
// TODO: count patches somehow.
true
let count = {
let doc = self.document.read();
let changes = doc.automerge.get_changes(&self.last_heads);
changes.len()
};
let has_patches = count > 0;
self.patches_since_last_save = self.patches_since_last_save.checked_add(count).unwrap_or(0);
has_patches
}

fn resolve_change_observers(&mut self, result: Result<(), RepoError>) {
Expand All @@ -708,18 +721,21 @@ impl DocumentInfo {
return;
}
let should_compact = self.patches_since_last_save > 10;
let storage_fut = if should_compact {
let to_save = {
let mut doc = self.document.write();
doc.automerge.save()
let (storage_fut, new_heads) = if should_compact {
let (to_save, new_heads) = {
let doc = self.document.read();
(doc.automerge.save(), doc.automerge.get_heads())
};
storage.compact(document_id.clone(), to_save)
(storage.compact(document_id.clone(), to_save), new_heads)
} else {
let to_save = {
let mut doc = self.document.write();
doc.automerge.save_incremental()
let (to_save, new_heads) = {
let doc = self.document.read();
(
doc.automerge.save_after(&self.last_heads),
doc.automerge.get_heads(),
)
};
storage.append(document_id.clone(), to_save)
(storage.append(document_id.clone(), to_save), new_heads)
};
match self.state {
DocState::Sync(ref mut futs) => {
Expand All @@ -733,6 +749,7 @@ impl DocumentInfo {
let waker = Arc::new(RepoWaker::Storage(wake_sender.clone(), document_id));
self.state.poll_pending_save(waker);
self.patches_since_last_save = 0;
self.last_heads = new_heads;
}

/// Apply incoming sync messages,
Expand Down