Remove hyperparameter in a configuration space #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herilalaina
changed the title
eddiebergman
requested changes
Jul 7, 2023
|
I have added a few tests to cover different cases. Let me know if you have any specific scenarios that should be included. |
|
@herilalaina where are we with that feature? |
|
I have added the requested tests already. @eddiebergman is there anything I missed again? :) |
|
Maybe, it just completely slipped my stack. I'll take a look next week when I'm back! |
|
Hi @herilalaina and @simonprovost, There is an issue in that using Cython 3 to compile ConfigSpace doesn't work anymore as it now expects more rigid typing (of which there are quite a few inconsistencies). I will manually edit and merge this PR once the PR at #346 is done |
|
Will keep this open in the time being, #346 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267.
This PR creates a new feature that allows removing a hyperparameter in a configuration space. The implementation is built upon the initial code given by @eddiebergman in the mentioned issue, mainly also to remove the conditions and forbidden clauses referenced by the hyperparameter.