Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbidden Relations of Disabled Hyperparameters #397

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Forbidden Relations of Disabled Hyperparameters #397

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84899b7
avoid evaluating forbidden relations on HPOs that were disabled/not s…
Nov 19, 2024
166e8aa
- add nan checks for single vals, not just arrays, before evaluating …
Nov 20, 2024
e5c525c
- aesthetic refactor: rename for improved legibility
Nov 20, 2024
1673f3a
test all forbidden relations, not just equals
Nov 20, 2024
5ebe8e4
rearrange some code to pass ruff formatter check
Nov 21, 2024
1c207f2
run ruff format on the entire project, not just on src subdir
Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/ConfigSpace/forbidden.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,10 @@ def is_forbidden_vector(self, vector: Array[f64]) -> bool:
def is_forbidden_vector_array(self, arr: Array[f64]) -> Mask:
left = arr[self.vector_ids[0]]
right = arr[self.vector_ids[1]]
return self.left.to_value(left) < self.right.to_value(right)
mask = ~(np.isnan(left) | np.isnan(right))
out = np.zeros_like(mask)
out[mask] = self.left.to_value(left[mask]) < self.right.to_value(right[mask])
return out


class ForbiddenEqualsRelation(ForbiddenRelation):
Expand Down Expand Up @@ -686,7 +689,10 @@ def is_forbidden_vector(self, vector: Array[f64]) -> bool:
def is_forbidden_vector_array(self, arr: Array[f64]) -> Mask:
left = arr[self.vector_ids[0]]
right = arr[self.vector_ids[1]]
return self.left.to_value(left) == self.right.to_value(right) # type: ignore
mask = ~(np.isnan(left) | np.isnan(right))
out = np.zeros_like(mask)
out[mask] = self.left.to_value(left[mask]) == self.right.to_value(right[mask])
return out # type: ignore


class ForbiddenGreaterThanRelation(ForbiddenRelation):
Expand Down Expand Up @@ -751,7 +757,10 @@ def is_forbidden_vector(self, vector: Array[f64]) -> bool:
def is_forbidden_vector_array(self, arr: Array[f64]) -> Mask:
left = arr[self.vector_ids[0]]
right = arr[self.vector_ids[1]]
return self.left.to_value(left) > self.right.to_value(right)
mask = ~(np.isnan(left) | np.isnan(right))
out = np.zeros_like(mask)
out[mask] = self.left.to_value(left[mask]) > self.right.to_value(right[mask])
return out


ForbiddenLike = Union[
Expand Down
Loading