fix(exploration): typo self.ago -> self.algo in sample_func_logits#117
Open
jmtoepperwien wants to merge 1 commit into
Open
fix(exploration): typo self.ago -> self.algo in sample_func_logits#117jmtoepperwien wants to merge 1 commit into
jmtoepperwien wants to merge 1 commit into
Conversation
In MightyExplorationPolicy.sample_func_logits, the sac flag passed to sample_nondeterministic_logprobs used self.ago instead of self.algo. Because self.ago does not exist, this always resolved to False, meaning the tanh-squash correction was never applied for SAC in this code path.
ec3778b to
2759cfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
MightyExplorationPolicy.sample_func_logits, thesacflag passed tosample_nondeterministic_logprobsusedself.agoinstead ofself.algo.Impact
Because
self.agodoes not exist, the expression always evaluated toFalse, so the tanh-squash log-probability correction was never applied for SAC in this code path — even though SAC requires it. This caused old log-probs stored in the rollout buffer to be plain Gaussian log-probs without the tanh correction, introducing a systematic bias in the PPO importance-sampling ratio.