Show incorrect/suboptimal reflection usage advice #1614
+288
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only interested in Class.forName which is a static call
patrick-dedication
force-pushed
the
pdedication.add-test-for-broken-reflection-usage-advice
branch
2 times, most recently
from
725ef2d to
b31a69c
Compare
patrick-dedication
force-pushed
the
pdedication.add-test-for-broken-reflection-usage-advice
branch
from
b31a69c to
9eec055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure if this should be an ignored test or a passing test with "wrong" assertions.
Either way more than happy to work on an improvement if there is a clear direction what would be an improvement :)
Also unsure if this should be a draft or not.