Modified Geneious download recipe to support latest version (2019) #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the download url for Geneious Prime slightly diverges from the information found in the versions.txt an additional RegexReplace Processor is required. With the modified download recipe both version (20 and 2019) can be downloaded by modifiying the input variables.
chelming
requested changes
Apr 3, 2019
Author
Author
|
I'll test and merge this tomorrow. |
Author
|
Bump @CWhits |
chelming
requested changes
Jul 10, 2019
chelming
left a comment
chelming
left a comment
There was a problem hiding this comment.
check the formatting on the regex replace processor. I don't think it will work as-is.
| </dict> | ||
| <dict> | ||
| <key>Processor</key> | ||
| <string>RegexReplace</string> |
There was a problem hiding this comment.
I believe this needs to be formatted like so:
<string>com.github.n8felton.shared/RegexReplace</string>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the download URL for Geneious Prime slightly diverges from the
information found in the versions.txt an additional RegexReplace Processor is required.
With the modified download recipe both versions (20 and 2019) can be downloaded by
modifying the input variables.
As discussed in autopkg/autopkg#442 it makes more sense to add the processor for only this recipe, as not many other recipes currently need a RegexReplace processor.