Merge pull request #380 from dean985/fix/go-to-navigation-error

fix: raise NavigationError when go_to fails

Author: thalissonvs

pydoll/browser/tab.py

@@ -51,6 +51,7 @@
     InvalidScriptWithElement,
     InvalidTabInitialization,
     MissingScreenshotPath,
+    NavigationError,
     NetworkEventsNotEnabled,
     NoDialogPresent,
     NotAnIFrame,
@@ -112,6 +113,7 @@
         CaptureScreenshotResponse,
         GetResourceContentResponse,
         GetResourceTreeResponse,
+        NavigateResponse,
         PrintToPDFResponse,
     )
     from pydoll.protocol.runtime.methods import CallFunctionOnResponse, EvaluateResponse
@@ -892,22 +894,20 @@ async def go_to(self, url: str, timeout: int = 300):
         """
         Navigate to URL and wait for loading to complete.
 
-        Refreshes if URL matches current page.
-
         Args:
             url: Target URL to navigate to.
             timeout: Maximum seconds to wait for page load (default 300).
 
         Raises:
+            NavigationError: If the navigation fails (e.g., DNS error).
             PageLoadTimeout: If page doesn't finish loading within timeout.
         """
         logger.info(f'Navigating to URL: {url} (timeout={timeout}s)')
-        if await self._refresh_if_url_not_changed(url):
-            logger.debug('URL matches current page; refreshing instead')
-            return
-
         async with self._wait_page_load(timeout=timeout):
-            await self._execute_command(PageCommands.navigate(url))
+            response: NavigateResponse = await self._execute_command(PageCommands.navigate(url))
+            error_text = response['result'].get('errorText')
+            if error_text:
+                raise NavigationError(url, error_text)
         logger.info(f'Navigation complete: {url}')
 
     async def refresh(
@@ -1821,14 +1821,6 @@ def _get_evaluate_command(
             serialization_options=serialization_options,
         )
 
-    async def _refresh_if_url_not_changed(self, url: str) -> bool:
-        """Refresh page if URL hasn't changed."""
-        current_url = await self.current_url
-        if current_url == url:
-            await self.refresh()
-            return True
-        return False
-
     @staticmethod
     def _validate_argument_error(response: EvaluateResponse) -> None:
         """

pydoll/exceptions.py

@@ -211,6 +211,17 @@ class DownloadTimeout(TimeoutException):
     message = 'Timed out waiting for download to complete'
 
 
+class NavigationError(PydollException):
+    """Raised when page navigation fails (e.g., DNS resolution failure)."""
+
+    def __init__(self, url: str, error_text: str):
+        self.url = url
+        self.error_text = error_text
+        super().__init__(
+            message=f'Navigation to {url} failed: {error_text}',
+        )
+
+
 class ConfigurationException(PydollException):
     """Base class for exceptions related to configuration and options."""
 

tests/test_browser/test_browser_tab.py

@@ -389,7 +389,6 @@ class TestTabNavigation:
     async def test_go_to_new_url(self, tab):
         """Test navigating to a new URL."""
         tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://old-url.com'}}},  # current_url
             {'result': {}},  # Page.enable
             {'result': {'frameId': 'frame-id'}},  # navigate command
             {'result': {}},  # Page.disable
@@ -403,15 +402,37 @@ async def fire_callback(event_name, callback, temporary=False):
 
         await tab.go_to('https://example.com')
 
-        assert tab._connection_handler.execute_command.call_count == 4
+        assert tab._connection_handler.execute_command.call_count == 3
+
+    @pytest.mark.asyncio
+    async def test_go_to_navigation_error(self, tab):
+        """Test that navigation errors raise NavigationError."""
+        from pydoll.exceptions import NavigationError
+
+        tab._connection_handler.execute_command.side_effect = [
+            {'result': {}},  # Page.enable
+            {'result': {'frameId': 'f', 'errorText': 'net::ERR_NAME_NOT_RESOLVED'}},
+            {'result': {}},  # Page.disable
+        ]
+
+        async def fire_callback(event_name, callback, temporary=False):
+            callback({'method': event_name, 'params': {}})
+            return 1
+
+        tab._connection_handler.register_callback = AsyncMock(
+            side_effect=fire_callback
+        )
+
+        with pytest.raises(NavigationError) as exc_info:
+            await tab.go_to('https://nonexistent.invalid')
+        assert 'net::ERR_NAME_NOT_RESOLVED' in str(exc_info.value)
 
     @pytest.mark.asyncio
     async def test_go_to_same_url(self, tab):
-        """Test navigating to the same URL (should refresh)."""
+        """Test navigating to the same URL works the same as a new URL."""
         tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://example.com'}}},  # current_url
             {'result': {}},  # Page.enable
-            {'result': {}},  # refresh command
+            {'result': {'frameId': 'frame-id'}},  # navigate command
             {'result': {}},  # Page.disable
         ]
 
@@ -423,13 +444,12 @@ async def fire_callback(event_name, callback, temporary=False):
 
         await tab.go_to('https://example.com')
 
-        assert tab._connection_handler.execute_command.call_count == 4
+        assert tab._connection_handler.execute_command.call_count == 3
 
     @pytest.mark.asyncio
     async def test_go_to_timeout(self, tab):
         """Test navigation timeout."""
         tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://old-url.com'}}},  # current_url
             {'result': {}},  # Page.enable
             {'result': {'frameId': 'frame-id'}},  # navigate command
             {'result': {}},  # Page.disable
@@ -1827,38 +1847,6 @@ async def fire_callback(event_name, callback, temporary=False):
 
         assert tab._page_events_enabled is False
 
-    @pytest.mark.asyncio
-    async def test_refresh_if_url_not_changed_same_url(self, tab):
-        """Test _refresh_if_url_not_changed with same URL."""
-        tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://example.com'}}},  # current_url call
-            {'result': {}},  # Page.enable
-            {'result': {}},  # refresh call
-            {'result': {}},  # Page.disable
-        ]
-
-        async def fire_callback(event_name, callback, temporary=False):
-            callback({'method': event_name, 'params': {}})
-            return 1
-
-        tab._connection_handler.register_callback = AsyncMock(side_effect=fire_callback)
-
-        result = await tab._refresh_if_url_not_changed('https://example.com')
-
-        assert result is True
-        assert tab._connection_handler.execute_command.call_count == 4
-
-    @pytest.mark.asyncio
-    async def test_refresh_if_url_not_changed_different_url(self, tab):
-        """Test _refresh_if_url_not_changed with different URL."""
-        tab._connection_handler.execute_command.return_value = {
-            'result': {'result': {'value': 'https://different.com'}}
-        }
-        
-        result = await tab._refresh_if_url_not_changed('https://example.com')
-        
-        assert result is False
-        assert_mock_called_at_least_once(tab._connection_handler)
 
 
 class TestTabRequestManagement: