Skip to content

refactor: pydoll v2#132

Merged
thalissonvs merged 162 commits into
mainfrom
refactor/v2
Jun 8, 2025
Merged

refactor: pydoll v2#132
thalissonvs merged 162 commits into
mainfrom
refactor/v2

Conversation

@thalissonvs
Copy link
Copy Markdown
Member

@thalissonvs thalissonvs commented May 28, 2025

Refactoring Pull Request

Refactoring Scope

All codebase

Description

This refactoring aims to facilitate future maintenance. The file structure was reorganized for better readability, and type hints were added to improve robustness.

API Changes

  • No changes to public API
  • Public API changed, but backward compatible
  • Breaking changes to public API

Testing Checklist

  • Existing tests updated
  • New tests added for previously uncovered cases
  • All tests pass
  • Code coverage maintained or improved

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a thorough self-review of the refactored code
  • I have commented my code, particularly in complex areas
  • I have updated documentation if needed
  • I have run poetry run task lint and fixed any issues
  • I have run poetry run task test and all tests pass
  • My commits follow the conventional commits style

thalissonvs

This comment was marked as resolved.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 7, 2025

Codecov Report

Attention: Patch coverage is 98.77532% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pydoll/browser/tab.py 94.33% 15 Missing ⚠️
pydoll/browser/interfaces.py 75.00% 5 Missing ⚠️
pydoll/browser/managers/browser_process_manager.py 84.21% 3 Missing ⚠️
pydoll/browser/chromium/base.py 98.85% 2 Missing ⚠️
pydoll/commands/dom_commands.py 99.65% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thalissonvs
Copy link
Copy Markdown
Member Author

@cleitonleonel I fixed the tests. Can you test the lib and try to find some bugs? It would help a lot

@cleitonleonel
Copy link
Copy Markdown
Contributor

@cleitonleonel I fixed the tests. Can you test the lib and try to find some bugs? It would help a lot

Sure, bro, I'll do that.

@thalissonvs thalissonvs merged commit 0799695 into main Jun 8, 2025
11 checks passed
@thalissonvs thalissonvs deleted the refactor/v2 branch June 8, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants