Skip to content

update msg for virsh hypervisor_cpu_compare with virsh capa #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nanli1 wants to merge 1 commit into from
Closed

update msg for virsh hypervisor_cpu_compare with virsh capa #6271

nanli1 wants to merge 1 commit into from

Conversation

@nanli1
Copy link
Contributor

@nanli1 nanli1 commented Apr 8, 2025 •
edited
Loading

hypervisor_cpu_compare with virsh capabilities result are not
recommanded in Bug xxxx-79460

Signed-off-by: nanli [email protected]

virsh.hypervisor_cpu_compare.cpu_xml.f_capa_xml
virsh.hypervisor_cpu_compare.capa_xml

@nanli1 nanli1 marked this pull request as draft April 8, 2025 13:26
@nanli1 nanli1 marked this pull request as ready for review April 8, 2025 13:27
@nanli1
update msg for virsh hypervisor_cpu_compare with virsh capa
79ef12e 
  hypervisor_cpu_compare with virsh capabilities result are not
recommanded
Signed-off-by: nanli <[email protected]>
@nanli1 nanli1 force-pushed the update_hypervisor_cpu_compare_prompt_msg branch from f4b48ca to 79ef12e Compare April 8, 2025 13:28
@nanli1 nanli1 marked this pull request as draft April 8, 2025 13:30
@nanli1 nanli1 marked this pull request as ready for review August 26, 2025 02:39
smitterl
smitterl requested changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@smitterl smitterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your PR description, sorry. Do you mean to say this PR is not ready for review yet? If so, please set status = Draft.

smitterl
smitterl reviewed Sep 1, 2025
View reviewed changes
Copy link
Contributor

@smitterl smitterl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't understand your cmmit message

hypervisor_cpu_compare with virsh capabilities result are not
recommanded

Please update. IIUC, you update the test cases for when the host cpu is used for comparison, that there's an error message indicating in those cases the comparison might lead to incorrect results?

@nanli1
Copy link
Contributor Author

nanli1 commented Sep 5, 2025

@smitterl hi Sebas , Thanks your comment, This pr is due to bug RHEL-79460.
At first, dev said we don't recommend to check virsh hypervisor_cpu_compare with virsh capabilities and fixed it in prompting error msg , so I pushed this pr for this scenarios to status_error="yes" , but later he fixed it with warning msg , so we don't need to update this pr , I would close it.

@nanli1 nanli1 closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smitterl smitterl smitterl requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nanli1 @smitterl