Enhance avocado_guest test to run host tests in guest#4440
Enhance avocado_guest test to run host tests in guest#4440narasimhan-v wants to merge 1 commit intoautotest:masterfrom
Conversation
WalkthroughThe change updates generic/tests/avocado_guest.py: default Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@generic/tests/avocado_guest.py`:
- Around line 45-47: The check for result after calling
avocado_obj.run_avocado() is dead because run_avocado() raises on failure when
called with ignore_result=False; either remove the unreachable lines that call
test.fail(...) (delete the if not result block) or change the call to
run_avocado(ignore_result=True) so it returns a boolean and keep the subsequent
if not result: test.fail(...) handling; locate the call to
avocado_obj.run_avocado() and the test.fail() usage to apply one of these two
changes consistently.
avocado_guest test runs any avocado-misc host test in the guest. This patch adds test repo branch parameter, and adds logic to parse test results and fails accordingly. Signed-off-by: Narasimhan V <16101053+narasimhan-v@users.noreply.github.com>
8860680 to
53e381e
Compare
avocado_guest test runs any avocado-misc host test in the guest. This patch adds test repo branch parameter, and adds logic to parse test results and fails accordingly.
Depends on avocado-framework/avocado-vt#4319
Summary by CodeRabbit
New Features
Bug Fixes
Chores