Standardize sev snp policy

[YvanY0]

Standardize SNP policy configuration to use vm_sev_policy parameter, providing consistent configuration across all AMD SEV technology variants (SEV → SEV-ES → SEV-SNP). And also Change SEV policy values from decimal to hexadecimal format to align with QEMU and libvirt documentation standards.

ID: 5134

Summary by CodeRabbit

• Refactor

  • Standardized SEV/SNP policy values to hexadecimal representation and unified policy key naming for consistency across configurations.
  • Simplified test logic to use numeric policy values for comparisons.

• Bug Fix

  • Introduced a default SEV policy value to avoid missing-parameter issues and ensure deterministic test outcomes.

[coderabbitai]

Walkthrough

Configuration files switch numeric SEV/SNP policy literals from decimal to hexadecimal and consolidate per-variant SNP policy settings (snp_policy + vm_secure_guest_object_options) into a single vm_sev_policy key. Test code updates read numeric policies via vm.params.get_numeric(...) (one with default 196608 for SNP test, another with default 3 for SEV basic), remove string-based parsing, and compare numeric values against QMP-reported policy fields. No other control flow or behavioral semantics are changed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly reflects the main change: standardizing SEV/SNP policy configuration and representation across the codebase.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[JinLiul]

with avocado-framework/avocado-vt#4329
sev and snp test cases passed.

[coderabbitai]

🧹 Nitpick comments (1)

qemu/tests/snp_basic_config.py (1)

70-70: Use a hex literal for default SNP policy for consistency.

At Line 70, consider replacing 196608 with 0x30000 to match the policy-format standardization goal and improve readability.

Proposed consistency tweak

-    vm_policy_int = vm.params.get_numeric("vm_sev_policy", 196608)
+    vm_policy_int = vm.params.get_numeric("vm_sev_policy", 0x30000)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@qemu/tests/snp_basic_config.py` at line 70, Replace the decimal default
literal 196608 used in the vm.params.get_numeric call with a hex literal to
improve readability and consistency; update the call
vm.params.get_numeric("vm_sev_policy", 196608) to use 0x30000 as the default for
vm_policy_int (referencing vm_policy_int, vm.params.get_numeric, and
"vm_sev_policy").

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@qemu/tests/snp_basic_config.py`:
- Line 70: Replace the decimal default literal 196608 used in the
vm.params.get_numeric call with a hex literal to improve readability and
consistency; update the call vm.params.get_numeric("vm_sev_policy", 196608) to
use 0x30000 as the default for vm_policy_int (referencing vm_policy_int,
vm.params.get_numeric, and "vm_sev_policy").

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37fb7463-be2f-4a99-a67f-1e57aa5aa4c1

📥 Commits

Reviewing files that changed from the base of the PR and between cab3bd5 and 0c9f727.

📒 Files selected for processing (7)

• qemu/tests/cfg/sev_basic_config.cfg
• qemu/tests/cfg/sev_dhcert_boot.cfg
• qemu/tests/cfg/sev_hotplug_mem.cfg
• qemu/tests/cfg/snp_attestation.cfg
• qemu/tests/cfg/snp_basic_config.cfg
• qemu/tests/sev_basic_config.py
• qemu/tests/snp_basic_config.py

✅ Files skipped from review due to trivial changes (4)

• qemu/tests/cfg/sev_dhcert_boot.cfg
• qemu/tests/cfg/sev_basic_config.cfg
• qemu/tests/sev_basic_config.py
• qemu/tests/cfg/sev_hotplug_mem.cfg

🚧 Files skipped from review as they are similar to previous changes (2)

• qemu/tests/cfg/snp_attestation.cfg
• qemu/tests/cfg/snp_basic_config.cfg