-
Notifications
You must be signed in to change notification settings - Fork 14
Update for nested fields #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
d6a8eb0
Add test for append handler
cat-wates def1403
Add utils for finding new nested fields
shugewang 3e6331e
Add to dos
shugewang a9ac57a
Append missing fields to target table fields
cat-wates a1d8a83
[WIP] reconstruction logic
cat-wates be542cc
Refactor utils to use FieldLineage class, change append_new_fields to…
shugewang 0e1bfd8
WIP - add failing test for build_predicted_table() and minor refactoring
shugewang 89a489e
WIP - add missing fields and build predicted table
shugewang 58c9c24
Add unit tests for add_missing_fields
shugewang 1dd4875
Delete sample test
cat-wates e4b36f8
Change append_new_columns_handler to use util functions
cat-wates 7c3c1ae
Add test for preserving nest column order
cat-wates 169b9bb
Rename
shugewang 6175011
build_predicted_table -> build_predicted_fields
shugewang 19d289f
Refactor build_predicted_fields to work for sync_all_columns handler
shugewang 1f78320
Add more tests for schema change handlers
shugewang 5a03b09
Formating
shugewang 5380476
Limit number of nested record types to 15 to match BQ limit
shugewang debc9db
Set max level of recursion for collect_field_lineages
shugewang 0a41cb7
Test repeated structs (arrays) are supported
shugewang 81dd0ce
Comment
shugewang 22cec77
Refactor FieldPath class to use tuple instead of str for path
shugewang 2940522
Rename functions and util file
shugewang 5ea0134
Add integration test
shugewang 748a7e8
Rename test file
shugewang 5e6595c
WIP - make test sql non-recursive (test now failing as result)
shugewang 387476c
WIP - remove obviated test and change common_field_names() to return …
shugewang a21e8df
WIP - add error handling for removing nested field, failing integrati…
shugewang 5b41014
dry runner will object to removing fields from within records/structs
evie-autotrader 5371bb7
add limitation to README
evie-autotrader af4a53a
formatting, linting, type checking
evie-autotrader a52c282
separate methods to check adding vs removing fields from nested structs
evie-autotrader 5a1a198
Remove comments
shugewang 0c4ab6b
Refactor - test names
shugewang 047fb3a
Linting
shugewang 9e434ed
add Evie to authors
evie-autotrader e11ae1f
fix indentation
evie-autotrader 26e3a34
update limitations
evie-autotrader be16e4d
rename get_updated_schema
evie-autotrader eed1476
rename ensure_no_removed_nested_fields
evie-autotrader faee492
add is_top_level property to table FieldPath
evie-autotrader 89cf194
make references to missing fields more specific
evie-autotrader cdbe714
rename collect field paths method to add context
evie-autotrader ec4c817
refactor to add context around missing fields and make error messages…
evie-autotrader 86037eb
Refactor sync_all_columns_handler logic for removing top level fields
shugewang 8305489
partial refactor for abstraction
evie-autotrader b080919
New test, linting
shugewang d086a0d
rename nested_schema_change to remove unneeded qualifier
evie-autotrader 3333368
Fix imports
shugewang 247c35c
refactor - make nested field removal check more abstract
evie-autotrader da5987c
refactored to clarify responsibilities and privacy of schema_change m…
evie-autotrader e7b0b3b
Rename functions
shugewang bb90992
WIP - renaming in merge_table_fields
shugewang 118aa5a
test cases for merge_table_fields
evie-autotrader b4a15a4
schema change handlers raise error when nested field removed
evie-autotrader 23a7015
Make methods in schema_manipulation role-agnostic
shugewang 25728e3
WIP - add fail handler integration tests (nested failing)
shugewang 3acc558
Update fail_handler to detect nested changes
shugewang 0d47ad5
Refactor assert_no_nested_fields_removed to use is_top_level property
shugewang 23c1bc0
Add path to TableField, removing the need for FieldPath. Move _collec…
shugewang 40c50bf
Move assert to schema_change_handlers.py
evie-autotrader 671f548
remove path property from TableField, recreate FieldPath type class
evie-autotrader b57986a
bump version and add details to changelog
evie-autotrader File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.